'Unnecessary' hint fades out only first token

[chrmarti]

Issue Type: Bug

Testing #52218

The 'unnecessary' hint spans the entire document, only the first token is faded:

VS Code version: Code - Insiders 1.25.0-insider (f2fa6be, 2018-06-27T05:11:02.122Z)
OS version: Darwin x64 17.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (1.15GB free)
Process Argv	/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron --extensions-dir /Users/chrmarti/Development/repos/tmp/ext --user-data-dir /Users/chrmarti/Development/repos/tmp/user
Screen Reader	no
VM	20%

Extensions: none

[Gama11]

Are there plans to address this in the near future (since it's not assigned to a milestone or tagged as a bug)?

I ran into this when trying to use the new API to fade out inactive conditional compilation blocks in the Haxe extension.

I noticed that if the severity is != Hint, the fading also works properly across the entire range:

Of course, that leaves you with some undesirable squiggly lines, so it's not very useful in practice - but maybe it helps with finding the source of the bug.

---

Some test code I wrote to isolate it (before finding this issue):

import * as vscode from "vscode";

export function activate(context: vscode.ExtensionContext) {
	var diagnostics = vscode.languages.createDiagnosticCollection("foo");
	vscode.window.onDidChangeActiveTextEditor(editor => {
		if (editor != null) {
			var doc = editor.document;
			var range = new vscode.Range(new vscode.Position(0, 0), new vscode.Position(doc.lineCount, doc.lineAt(doc.lineCount - 1).lineNumber));
			var diagnostic = new vscode.Diagnostic(range, "Inactive section", vscode.DiagnosticSeverity.Hint);
			diagnostic.tags = [vscode.DiagnosticTag.Unnecessary];
			diagnostics.set(editor.document.uri, [diagnostic]);
		}
	});
}

[mjbvz]

Fixed by e659ffd