Git "push to..." menu doesn't show an error if it fails

[mcintyre94]

Issue Type: Bug

• Check out a branch that's synced, git commit --amend to change the hash of the last commit.
• From the Source control: Git sidebar, select ... -> "push to...", then origin

The push will fail - as it should because your history doesn't match so you'd need to force push, but you don't get any error message to inform you that it failed.

If you instead use the ... -> Push option, then you get an error suggesting to git pull before pushing. I assume that this same error should be used for push to... as well.

VS Code version: Code 1.24.1 (24f6262, 2018-06-13T17:41:50.128Z)
OS version: Darwin x64 17.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 2, 2
Memory (System)	8.00GB (0.07GB free)
Process Argv	/Applications/Visual Studio Code.app/Contents/MacOS/Electron
Screen Reader	no
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
scala-lsp	dra	0.2.3
Sbt	itr	0.1.7
python	ms-	2018.6.0
markdown-preview-enhanced	shd	0.3.5

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Git option "Push" is not greyed anymore right after push (#24201)
• Add git force push (#53170)
• Add support for Git force push within the editor. (#53045)
• Feature Request: ability to review 'git push' and compare to remote (#22238)
• Do not offer to push to Git if remote push URL is no_push (#45271)

[joaomoreno]

/duplicate #41519

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!