Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Suggest" triggers in non-focused group, causing focus to shift away from current group #57234

Closed
garyking opened this issue Aug 26, 2018 · 6 comments
Assignees

Comments

@garyking
Copy link

garyking commented Aug 26, 2018

  • VSCode Version: Version 1.26.1 (1.26.1)
  • OS Version: 10.13.5 (17F77)

Steps to Reproduce:

This is a continuation of #47858, another issue of mine from April. I was unable to figure out how to reproduce it, until now.

The following steps are also illustrated in a GIF below.

  1. Have two tab groups of the same file.
  2. Create a JS file with these contents:
function join(value1, value2) {
  return value1 + value2
}

join(value1, value2)
  1. In the first group, delete the value2 until it's va, so that the tooltip appears.
  2. Switch to the second group. The tooltip will then close, as expected.
  3. In the second group, modify the function params, such as by deleting some text.
  4. The tooltip suddenly appears in group 1, taking focus away from group 2. If you were to be typing something at the time, then once focus is switched to group 1, the subsequent text you type will be entered there instead.

Maybe don't allow non-focused groups to show Suggest/IntelliSense tooltips? Or don't allow them to take away focus.

tab group focus

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Aug 26, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@ramya-rao-a
Copy link
Contributor

This looks similar to #54545

Can you try our Insiders and see if you see the same there?

@garyking
Copy link
Author

Yes seems fixed in Insiders, after copying the steps I mentioned above. I notice the change was made on August 6, yet 1.26 was released on August 14. Why did the change not make it into that release? I assume it will be in the next one?

@ramya-rao-a
Copy link
Contributor

Code freeze for 1.26 was July 30 and so this fix didn't make it to the 1.26 release
Yes, it will be available in the next update

@garyking
Copy link
Author

garyking commented Sep 5, 2018

Confirmed fixed in August 2018 release.

@ramya-rao-a
Copy link
Contributor

Thanks @garyking

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants