Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom title bar height is a bit too high on Windows #57823

Closed
borekb opened this issue Sep 3, 2018 · 6 comments
Closed

Custom title bar height is a bit too high on Windows #57823

borekb opened this issue Sep 3, 2018 · 6 comments
Assignees
Labels
invalid Issue identified as not relevant or not valid polish Cleanup and polish issue

Comments

@borekb
Copy link

borekb commented Sep 3, 2018

With "window.titleBarStyle": "custom" and the default dark theme on Windows 10, the title bar "wastes" a couple of pixels compared to the native title bar:

image

The height looks slightly out of place on my machine, compared to the other windows, and it's not obvious to me for what benefit.

(I hope this is not a duplicate, I searched and didn't find anything. Update: height is briefly discussed here: #39972 (comment).)

@bpasero bpasero removed their assignment Sep 4, 2018
@bpasero bpasero added workbench-menu polish Cleanup and polish issue labels Sep 4, 2018
@LasseRosenow
Copy link

Please keep it this way. It looks way more modern just like UWPs do.

@borekb
Copy link
Author

borekb commented Sep 4, 2018

Thank God VSCode isn't an UWP app :)

@sbatten
Copy link
Member

sbatten commented Sep 5, 2018

@FaulesLama are you saying you like the current titlebar sizing?

@sbatten sbatten added this to the On Deck milestone Sep 5, 2018
@LasseRosenow
Copy link

@sbatten Yes

@sbatten sbatten added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 10, 2018
@borekb
Copy link
Author

borekb commented Sep 11, 2018

Oh, I just realized window.zoomLevel affects the title bar in 'custom' mode, and I almost always use a value greater than zero for zoomLevel. I'd personally be happy with the title bar keeping the same size as in 'native' mode but I understand that the current behavior might be the desired one. Feel free to close this issue if you think this request is invalid.

@sbatten
Copy link
Member

sbatten commented Sep 11, 2018

@borekb Ah, okay. There was a time where we had the title bar staying the same size with the custom menu bar, but we decided zoom level should be honored for the accessibility reasons. Thanks for understanding.

@sbatten sbatten closed this as completed Sep 11, 2018
@sbatten sbatten added invalid Issue identified as not relevant or not valid and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 11, 2018
@sbatten sbatten removed this from the On Deck milestone Sep 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid Issue identified as not relevant or not valid polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

4 participants