Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uri provided to editor/title commands is always the Uri of the right side of a diff view, even if the left side is focused #59188

Closed
eamodio opened this issue Sep 23, 2018 · 1 comment
Labels
*as-designed Described behavior is as designed

Comments

@eamodio
Copy link
Contributor

eamodio commented Sep 23, 2018

  • VSCode Version: 1.28.0-insider
  • OS Version: Windows 10 x64

Uri provided to editor/title commands is always the Uri of the right side of a diff view, even if the left side is focused

Steps to Reproduce:

  1. Create an extension with a editor/title command registered with commands.registerCommand
  2. Open a diff view (comparing 2 files, comparing git changes, etc) and move focus to the left side
  3. Click on the editor/title command and observe that the Uri provided to the callback is from right side and not the left.

Originally reported here:
#22403 (comment)

Does this issue occur when all extensions are disabled?: No

@vscodebot vscodebot bot added the insiders label Sep 23, 2018
@bpasero
Copy link
Member

bpasero commented Sep 24, 2018

I think this is actually working as intended. In a diff editor most commands target only the right hand side. We never update the editor actions when you switch focus between left or right hand side. Closing.

@bpasero bpasero closed this as completed Sep 24, 2018
@bpasero bpasero added the *as-designed Described behavior is as designed label Sep 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

2 participants