Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test search via FileSearchProvider and vscode-cached-search-provider lib #64274

Closed
2 tasks done
roblourens opened this issue Dec 4, 2018 · 3 comments
Closed
2 tasks done

Comments

@roblourens
Copy link
Member

roblourens commented Dec 4, 2018

Test #59922

Complexity: 2

Test that file search via the FileSearchProvider API and the extracted support library works correctly

  • Install https://marketplace.visualstudio.com/items?itemName=roblourens.test-search-rg
  • Start vscode with --enable-proposed-api roblourens.test-search-rg
  • Test that quick open search works fine
  • Single folder and multiroot scenarios are 👍
  • You can verify that the extension is handling search by setting the log level to "Trace", open Log (Window), do a file search, and you should not see logs starting with SearchService#search rg --files ... which come from bulitin search
@jrieken
Copy link
Member

jrieken commented Dec 4, 2018

@roblourens the extension is broken because it misses the extension.js file...

@jrieken
Copy link
Member

jrieken commented Dec 4, 2018

I have created a vsix locally after cloning https://github.com/roblourens/test-search-rg. 🤞 that I am testing the right thing now...

test-search-rg-0.0.3.vsix.zip

@roblourens
Copy link
Member Author

Yeah, sorry guys. Thanks @jrieken that's right. And @stevencl I forgot that the extension would only work on the platform that I published it on...

@stevencl Please test with these steps:

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @roblourens @stevencl @jrieken and others