-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Reveal in sidebar` does not work #68627
Comments
(Experimental duplicate detection) |
Same erratic behavior with latest 1.31.1. |
Same behaviour on Windows. |
same. |
Can somebody please provide exact reproducable steps? |
Steps for reproduce:
sidebar died Version 1.31.1 (1.31.1) error:
ERR Data tree node not found: [object Object]: Error: Data tree node not found: [object Object]
at i.e.getDataNode (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1037:266)
at i. (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1034:703)
at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:33:935
at Object.next (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:34:33)
at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:33:160
at new Promise ()
at i (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:32:952)
at i.e.expand (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1034:342)
at Array. (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5627:417)
at t (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:105:891)
at process._tickCallback (internal/process/next_tick.js:68:7)
|
Same behavior in vscode insiders:
VS Code version: Code - Insiders 1.32.0-insider (bbe40c8, 2019-02-18T10:48:16.325Z) System Info
Extensions (34)
(2 theme extensions excluded) |
@pustovalov thanks for steps and for trying with insiders, however I can not reproduce on my machine. Do you have some setting like explorer.autoReveal to false or something like that? Looking at the errors stack my assumption is that the issue happens here when I try to expand an element which is not known to the tree. |
@isidorn If you had a |
@joaomoreno if the tree does not have a node I would refresh the node's parent. |
Did not try to repro. This sounds like another argument for |
I have video: |
It happens to me every time I run a script (probably because it's altering the tree). |
I have the same problem with 1.31.1
|
I'm experiencing this as well, with the same error message in the console and it's back working after a reload. VS Code version: Code 1.31.1 (1b8e830, 2019-02-12T02:20:54.427Z) System Info
Extensions (23)
(4 theme extensions excluded) |
I am also experiencing this issue. Thanks for the screencast mode for to make that gif better! I have not noticed any particular actions that trigger this. I reloaded the window with extensions disabled, and still saw the problem. Interesting things to note:
|
@joaomoreno and me are having a hard time reproducing this issue, though we acknowledge there is an issue. |
Not always, but when that the infamous |
@isidorn have you guys tried to run some kind of building process? Something like For me it happens 100% of the times I run a build script, one is using a custom script to build a Roku package, and the other is when running |
Similar for me, running |
I have not yet been able to determine what triggers the problem. Reloading the window does not fix it. |
I'm experiencing this issue also. Restarting does fix it temporarily, but reoccurring again after a short time. |
Ok here are the repro steps.
|
Tomorrow's vscode insiders will contain the fix. Try it out and let us know how it behaves for you. The issue was that the explorer was trying to be smart and figure out which exact part of the tree to refresh on raw file event. Howeever since there can be many events sometimes it is better to just refresh the whole tree (which was the previous strategy). So I decided to go back to the old approach |
Awesome! Thanks. How will I know when "tomorrow's VSCode Insiders" version is available? I didn't see on the download page page any indication of when the published version was created. |
Issue Type: Bug
Actual: file could not be found in the sidebar
Expected: active file shows in the sidebar
Notes: after reboot VS code
reveal in sidebar
works but after some time it stops workingVS Code version: Code 1.31.0 (7c66f58, 2019-02-05T22:32:14.164Z)
OS version: Darwin x64 18.2.0
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Extensions (47)
(3 theme extensions excluded)
The text was updated successfully, but these errors were encountered: