Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Certificates loaded from OS #71108

Closed
3 tasks done
chrmarti opened this issue Mar 25, 2019 · 4 comments
Closed
3 tasks done

Test: Certificates loaded from OS #71108

chrmarti opened this issue Mar 25, 2019 · 4 comments

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Mar 25, 2019

#52880

Complexity: 3

Run the https-server.zip in a terminal.

Run this code in an extension:

https.get('https://localhost:3000', res => console.log(res.statusCode))
	.on('error', console.error);
  • Verify that the request fails because the certificate is self-signed.
  • Add the certificate (attached) to the root certificates of your OS. (See, e.g., https://www.bounca.org/tutorials/install_root_certificate.html)
  • Reload VS Code window to pick up the additional certificate.
  • Verify that the request succeeds.
  • Turn the http.systemCertificates setting off.
  • Verify that the request fails again.
  • Remove the certificate from the root certificates of your OS to clean up.
@chrmarti chrmarti added this to the March 2019 milestone Mar 25, 2019
@sandy081 sandy081 removed their assignment Mar 26, 2019
@sandy081
Copy link
Member

Verified as per the steps mentioned.

@roblourens roblourens removed their assignment Mar 26, 2019
@roblourens
Copy link
Member

Which one is the crt I added, is it the one called localhost?

image

@kieferrm
Copy link
Member

kieferrm commented Mar 26, 2019

FYI, on macOS, adding the key to the keychain did not suffice. I had to reboot my machine to make it effective.

@kieferrm kieferrm removed their assignment Mar 26, 2019
@chrmarti
Copy link
Collaborator Author

@roblourens Yep, it's the 3/7/2020 one.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants