Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to distinguish between diagnostics created by a reconciler and a builder #74524

Open
dbaeumer opened this issue May 29, 2019 · 3 comments
Assignees
Labels
api feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Milestone

Comments

@dbaeumer
Copy link
Member

Short summary: currently it is very hard to handle / merge diagnostics that come from to different source having the same owner. This either leads to stale problems or missing problems. For a lengthy discussion see #61140

Having support to distinguish between diagnostics create by a reconciler and a builder would help solve that problem.

@dbaeumer dbaeumer added api feature-request Request for new features or functionality labels May 29, 2019
@jrieken jrieken added the languages-diagnostics Source problems reporting label May 29, 2019
@dbaeumer dbaeumer changed the title Add support to distinguish between diagnostics create by a reconciler and a builder Add support to distinguish between diagnostics created by a reconciler and a builder May 31, 2019
@dbaeumer
Copy link
Member Author

One idea would be two have two different tags that can be used. @jrieken & @mjbvz would that be in line with the current diagnostic design?

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 15, 2019

@dbaeumer Are you talking about the DiagnosticTag? I think that would make sense.

Or we could make it even more explicit by adding something like a creator?: 'builder' | 'task'| ... field on diagnostics

@dbaeumer
Copy link
Member Author

@mjbvz yes I am talking about DiagnosticTag. The only disadvantage I see is that we need to search the array to determine whether a diagnostic is from a builder or a reconciler. Having a creator property would make this easier to distinguish.

@jrieken jrieken added this to the Backlog milestone Jan 13, 2020
@alexr00 alexr00 self-assigned this Jul 21, 2020
@alexr00 alexr00 assigned meganrogge and unassigned alexr00 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Projects
None yet
Development

No branches or pull requests

5 participants