Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Terminal.name returns empty string after calling createTerminal() #75071

Closed
formulahendry opened this issue Jun 7, 2019 · 3 comments
Closed
Assignees
Labels
api *as-designed Described behavior is as designed feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label

Comments

@formulahendry
Copy link
Member

  • VSCode Version: 1.35
  • OS Version: Windows

Steps to Reproduce:

  1. calling createTerminal()
  2. check the value of Terminal.name is empty string (which is not expected)
  3. wait for some time, the value of Terminal.name becomes normal

Related to #74233 (comment), as we could not use terminal.integrated.shell.<platform>. However, we could not use Terminal.name.

This issue has affect the Code Runner and Maven extension:

@vscodebot
Copy link

vscodebot bot commented Jun 7, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Jun 7, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 7, 2019

This is as designed since createTerminal is synchronous but setting of the name only happens once the process has launched (async). For now you can workaround this by polling until name is set.

@Tyriar Tyriar added api feature-request Request for new features or functionality labels Jun 7, 2019
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Oct 9, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 9, 2019

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *as-designed Described behavior is as designed feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants