Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: bring back the separator from debug to extensions viewlet #8149

Closed
bpasero opened this issue Jun 26, 2016 · 5 comments
Closed

Extensions: bring back the separator from debug to extensions viewlet #8149

bpasero opened this issue Jun 26, 2016 · 5 comments
Assignees
Labels
extensions Issues concerning extensions
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 26, 2016

I actually liked the separator because it made it very clear that extensions have nothing to do with the inner-loop of development.

I am not sure why it was removed in the first place.

@bpasero bpasero added the extensions Issues concerning extensions label Jun 26, 2016
@isidorn isidorn added this to the June 2016 milestone Jun 27, 2016
@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2016

I did not like the separator visually and I thought the extensions being on the end of the list is a clear enough of an indication. Thus I gave negatvie feedback to joao regarding the seperator.
Not sure if that influenced his decision to remove it.

If you have strong feeling about it - I will bring it back

@bpasero
Copy link
Member Author

bpasero commented Jun 27, 2016

@isidorn lets talk in the UX meeting.

@bgashler1
Copy link
Contributor

I personally don't like the look of it, even though I get the argument for it. There's also another reason why I don't think we should put it there (which I'll post on Slack).

@isidorn
Copy link
Contributor

isidorn commented Jun 30, 2016

As far as voting goes we are 3 against 1 for not using the seperator -> thus I am moving this to july, joao so he can decide. So we are shipping without the seperator, later it is easier to add it then to remove it.

@isidorn isidorn modified the milestones: July 2016, June 2016 Jun 30, 2016
@isidorn isidorn assigned joaomoreno and unassigned isidorn Jun 30, 2016
@joaomoreno
Copy link
Member

Well... although I agree with @bpasero, I will simply close this since I removed it because I got another issue that was the exact opposite of this, and Machete don't jump back and forward. Only forward.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

4 participants