Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline breakpoints flicker and jump #81716

Closed
jrieken opened this issue Oct 1, 2019 · 3 comments
Closed

Inline breakpoints flicker and jump #81716

jrieken opened this issue Oct 1, 2019 · 3 comments
Assignees
@roblourens
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
On Deck

Comments

@jrieken
Copy link
Member

jrieken commented Oct 1, 2019

re #81175

  • have inline breakpoints
  • click one, click it again and again
  • 🐛 everything is super nervous, instead of enabling/disabling breakpoints seem to disappear/reappear with the consequence of text being shifted around (related to Spacing too wide for inline breakpoints #81715)

Oct-01-2019 11-10-18

@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2019

The issue here is that we always re-render the breakpoints in the whole file when a breakpoint changes.
This obviously can be improved such that we re-render just the delta. However not for endgame week, so assigning to next Milestone.

@isidorn isidorn added debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues labels Oct 1, 2019
@isidorn isidorn added this to the October 2019 milestone Oct 1, 2019
@isidorn isidorn mentioned this issue Oct 2, 2019
Closed
@isidorn isidorn mentioned this issue Oct 18, 2019
Closed
@isidorn isidorn modified the milestones: October 2019, November 2019 Oct 25, 2019
@isidorn isidorn modified the milestones: November 2019, December 2019 Dec 4, 2019
@isidorn isidorn mentioned this issue Dec 12, 2019
Closed
@isidorn isidorn modified the milestones: January 2020, On Deck Jan 21, 2020
@taciomedeiros
Copy link

+1

@isidorn isidorn assigned roblourens and unassigned isidorn Aug 17, 2021
@roblourens
Copy link
Member

Seems fixed

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
4 participants
@roblourens @jrieken @isidorn @taciomedeiros