-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown: open preview to the side should be Ctrl/Cmd click, not Alt #8255
Comments
Yeah, I don't like ctrl/cmd but I take the consistency point... |
Actually, I take that back ;-) The Alt modifier is a menu item modifier and not an argument to the command. Since, it's the alternative action for a menu item I think the alt-key is a good choice. In that respect it's different from ctrl/cmd click on tree items which we lend from hyperlinks in browsers. The point of Alt is to show an alternative less common version of a menu. @bgashler1 I know you wanted to join in this discussion. Please go ahead ;-) |
Also, while we only honour |
Fyi, using Cmd/Ctrl in trees is also not a good idea because when multi select is on, Cmd/Ctrl is reserved for multi select. So, having Alt everywhere is maybe a good idea, but will break existing assumptions. |
Thanks for including me in. I think this would be good to discuss in UX meeting. I personally don't think it's very discoverable to use an Alt key to change a command. It's not a bad idea by any means, but I think it's unlikely many people will ever know about it. |
I do think it is common for Mac users but not for Linux/Windows users. |
After the discussion I opt to leave this with Alt |
let's leave it by alt |
Refs: #7945
At least that would be consistent with other places where we open to the side and matches old behaviour.
The text was updated successfully, but these errors were encountered: