Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: open preview to the side should be Ctrl/Cmd click, not Alt #8255

Closed
bpasero opened this issue Jun 28, 2016 · 8 comments
Closed

Markdown: open preview to the side should be Ctrl/Cmd click, not Alt #8255

bpasero opened this issue Jun 28, 2016 · 8 comments
Assignees
Labels
markdown Markdown support issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Refs: #7945

At least that would be consistent with other places where we open to the side and matches old behaviour.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Jun 28, 2016
@jrieken
Copy link
Member

jrieken commented Jun 28, 2016

Yeah, I don't like ctrl/cmd but I take the consistency point...

@jrieken jrieken added this to the June 2016 milestone Jun 28, 2016
@jrieken
Copy link
Member

jrieken commented Jun 28, 2016

Actually, I take that back ;-) The Alt modifier is a menu item modifier and not an argument to the command. Since, it's the alternative action for a menu item I think the alt-key is a good choice. In that respect it's different from ctrl/cmd click on tree items which we lend from hyperlinks in browsers. The point of Alt is to show an alternative less common version of a menu.

@bgashler1 I know you wanted to join in this discussion. Please go ahead ;-)

@jrieken
Copy link
Member

jrieken commented Jun 28, 2016

Also, while we only honour Cmd/Ctrl at the time of the click, Alt is being honoured while being over the menu item.

@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2016

Fyi, using Cmd/Ctrl in trees is also not a good idea because when multi select is on, Cmd/Ctrl is reserved for multi select.

So, having Alt everywhere is maybe a good idea, but will break existing assumptions.

@bgashler1
Copy link
Contributor

Thanks for including me in. I think this would be good to discuss in UX meeting. I personally don't think it's very discoverable to use an Alt key to change a command. It's not a bad idea by any means, but I think it's unlikely many people will ever know about it.

@bpasero
Copy link
Member Author

bpasero commented Jun 29, 2016

I do think it is common for Mac users but not for Linux/Windows users.

@jrieken
Copy link
Member

jrieken commented Jun 29, 2016

After the discussion I opt to leave this with Alt

@jrieken
Copy link
Member

jrieken commented Jun 30, 2016

let's leave it by alt

@jrieken jrieken closed this as completed Jun 30, 2016
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Jul 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

3 participants