Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test before and after decorator attachments #8268

Closed
1 task done
aeschli opened this issue Jun 28, 2016 · 0 comments
Closed
1 task done

Test before and after decorator attachments #8268

aeschli opened this issue Jun 28, 2016 · 0 comments

Comments

@aeschli
Copy link
Contributor

aeschli commented Jun 28, 2016

New API has been added to the extension host to add 'attachments' before and after a decoration.
ThemableDecorationRenderOptions.before/after
ThemableDecorationInstanceRenderOptions.before/after

Test:

  • before and after attachments on decoration types
  • before and after attachments on decoration instances
    • verify that styles on the dec instance overwrite the definitions made on the type
  • test text content as well as icon content
  • test with decorations that combine attachment decorations with inline text decorations (letterSpacing, color) and 'normal' text decorations such as border, outline
  • test corner cases for ranges. Empty range, full line range, adjacent ranges, same range
  • test light and dark styles for attachment decorations
  • test corder cases on styles (huge width/height...)
@aeschli aeschli added this to the June 2016 milestone Jun 28, 2016
@jrieken jrieken removed their assignment Jun 28, 2016
@jrieken jrieken closed this as completed Jun 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants