Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace vs search background color difference too subtle #8286

Closed
isidorn opened this issue Jun 28, 2016 · 1 comment
Closed

Replace vs search background color difference too subtle #8286

isidorn opened this issue Jun 28, 2016 · 1 comment
Assignees
@sandy081
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2016

#8184

Steps to Reproduce:

  1. I like how we use a different background color in the search box depending if we show search results or replaced results
  2. However the color difference is very subtle - it should be much more prominent IMHO
  3. You just change the transparency by 0.15 - maybe increase this, and also you might need different change based on light / dark theme
@isidorn isidorn added the search Search widget and operation issues label Jun 28, 2016
@isidorn isidorn changed the title Replace vs search theme background color difference too subtle Replace vs search background color difference too subtle Jun 28, 2016
@isidorn isidorn mentioned this issue Jun 28, 2016
Closed
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 28, 2016
@sandy081
Copy link
Member

This will be handled with #8302.

Duplicates #8302

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isidorn @sandy081