Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile syntax highlighting for escaped quotes is not quite right (Dockerfile language) #82988

Closed
bwateratmsft opened this issue Oct 21, 2019 · 2 comments
Closed

Dockerfile syntax highlighting for escaped quotes is not quite right (Dockerfile language) #82988

bwateratmsft opened this issue Oct 21, 2019 · 2 comments
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@bwateratmsft
Copy link
Contributor

Copy from @dlech original issue here: microsoft/vscode-docker#75

Given the following dockerfile snippet...

# setup a new user
COPY compiler.sudoers /etc/sudoers.d/compiler
RUN chmod 0440 /etc/sudoers.d/compiler && \
    adduser --disabled-password --gecos \"\" compiler && \
    usermod -a -G sudo compiler
USER compiler
WORKDIR /home/compiler
CMD ["/bin/bash"] ["--login"]

The escaped quotes after gecos appear to throw off the syntax highlighting.

image
@bwateratmsft bwateratmsft mentioned this issue Oct 21, 2019
Closed
@alexr00 alexr00 mentioned this issue Oct 21, 2019
Open
@alexr00
Copy link
Member

alexr00 commented Oct 21, 2019

Moved to upstream reop

@alexr00 alexr00 closed this as completed Oct 21, 2019
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels Oct 21, 2019
@bwateratmsft
Copy link
Contributor Author

bwateratmsft commented Oct 21, 2019 •
edited
Loading

Ah, sorry--didn't realize that file comes from further upstream.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwateratmsft @alexr00