Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace: Replace button should be outside of input field #8329

Closed
bpasero opened this issue Jun 28, 2016 · 4 comments
Closed

Replace: Replace button should be outside of input field #8329

bpasero opened this issue Jun 28, 2016 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues ux User experience issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Refs: #8184

I think this would make it easier to discover that you have to press the action to replace all. It also moves the design closer to the editor find widget:

image

@bpasero bpasero added ux User experience issues search Search widget and operation issues labels Jun 28, 2016
@sandy081
Copy link
Member

@bpasero True, idea is to make Find and Replace, Search and Replace look similar. Currently, we just have Replace all button in Search view. Since it is just a single button I placed it inside the input. I felt having it outside would make it left out from the rest of the Search UI.

Anyway, I would try that and see if it looks good.

@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2016

Yes it might look weird if it is alone, I wonder if we eventually have more buttons outside like the previous/next arrow?

@sandy081 sandy081 added this to the Backlog milestone Jun 28, 2016
@sandy081
Copy link
Member

Yeah that is down the line. Once we have more I would relayout them nicely.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Jul 5, 2016
@bpasero
Copy link
Member Author

bpasero commented Aug 12, 2016

Works for me now.

image

@bpasero bpasero closed this as completed Aug 12, 2016
@bpasero bpasero modified the milestones: August 2016, Backlog Aug 12, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search Search widget and operation issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants