Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: did we loose the upper limit for search results? #8369

Closed
bpasero opened this issue Jun 28, 2016 · 2 comments
Closed

Search: did we loose the upper limit for search results? #8369

bpasero opened this issue Jun 28, 2016 · 2 comments
Assignees
@bpasero
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority search Search widget and operation issues
Milestone
June 2016

Comments

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016 •
edited
Loading

Refs: #8184

When I now search for "e" in our workspace I seem to get all the results back? I think as long as I am not replacing, it is fine to cut the results as we used to.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Jun 28, 2016
@bpasero bpasero added the important Issue identified as high-priority label Jun 28, 2016
@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2016

Marking as important because even for replace I see the entire UI freezing and things getting slow. Imho as long as we are not fit for this in the UI we should maybe keep the 2000er limit alive even for replace.

@bpasero bpasero added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues and removed bug Issue identified by VS Code Team member as probable bug labels Jun 28, 2016
@sandy081 sandy081 added this to the June 2016 milestone Jun 28, 2016
@sandy081
Copy link
Member

Agreed.

@sandy081 sandy081 assigned bpasero and unassigned sandy081 Jun 29, 2016
@sandy081 sandy081 mentioned this issue Jun 30, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority search Search widget and operation issues
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
2 participants
@bpasero @sandy081