Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing a single character hides or shows indentation guides in unpredictable way #8428

Closed
kieferrm opened this issue Jun 28, 2016 · 4 comments
Closed

Changing a single character hides or shows indentation guides in unpredictable way #8428

kieferrm opened this issue Jun 28, 2016 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@kieferrm
Copy link
Member

Testing #8232. Create a simple file without any file extension. See before and after.

Before:
screen shot 2016-06-28 at 11 57 02 am

After:
screen shot 2016-06-28 at 11 44 38 am
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug editor labels Jun 29, 2016
@alexdima alexdima added this to the June 2016 milestone Jun 29, 2016
@alexdima
Copy link
Member

Same as #8427 , the indent guides now reflect the folding regions

@aeschli see copy-paste friendly version in the comments of #8427

@alexdima alexdima assigned aeschli and unassigned alexdima Jun 29, 2016
@aeschli aeschli assigned alexdima and aeschli and unassigned aeschli and alexdima Jun 29, 2016
@alexdima
Copy link
Member

It might be on my side, it is not clear to me how these indent guides should be rendered in this case. I am unsure if there is a "correct" way

@alexdima
Copy link
Member

IMHO not a blocker

@alexdima alexdima removed this from the June 2016 milestone Jun 29, 2016
@alexdima
Copy link
Member

alexdima commented Dec 14, 2017 •
edited
Loading

This has been fixed ~1 or 2 months ago when we rewrote the indent guide computation logic.

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 14, 2017
@alexdima alexdima added this to the December 2017/January 2018 milestone Dec 14, 2017
@alexdima alexdima removed the *duplicate Issue identified as a duplicate of another issue(s) label Dec 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 29, 2018
@chrmarti chrmarti added the verified Verification succeeded label Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
5 participants
@bpasero @kieferrm @alexdima @aeschli @chrmarti