Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] auto rename: auto-remove results in extra undo #86055

Closed
aeschli opened this issue Dec 3, 2019 · 2 comments
Closed

[html] auto rename: auto-remove results in extra undo #86055

aeschli opened this issue Dec 3, 2019 · 2 comments
Assignees
@octref
Labels
*as-designed Described behavior is as designed html HTML support issues

Comments

@aeschli
Copy link
Contributor

aeschli commented Dec 3, 2019 •
edited
Loading

Testing #85973

<html>
    <foo>

    </foo>
</html>
  • set cursor at the end of foo
  • insert space, space is only added to first element
  • undo
  • space is not removed (but added on the closing tag)

According to @jrieken this could be solved by adding a keybinding that takes over the space key when a certain context is set. It removes the multicursor and then inserts the space.
@aeschli aeschli added the html HTML support issues label Dec 3, 2019
@octref
Copy link
Contributor

octref commented Dec 5, 2019

I don't think we should do that. I use Vim and a keybinding wouldn't allow me to undo that stack with u.

When you are typing a space there I expect 99% of the users mean to actually write an id or attribute. If he doesn't and is planning to undo, an extra undo feels ok for me.

@octref octref closed this as completed Dec 5, 2019
@octref octref added the *as-designed Described behavior is as designed label Dec 5, 2019
@octref
Copy link
Contributor

octref commented Dec 5, 2019

Currently auto-rename-tag makes every edit two edits, and people don't even complain that to it, so I feel this is fine.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
*as-designed Described behavior is as designed html HTML support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octref @aeschli