Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back off from successive requests when sync results in a 401 #88317

Closed
Tyriar opened this issue Jan 8, 2020 · 4 comments
Closed

Back off from successive requests when sync results in a 401 #88317

Tyriar opened this issue Jan 8, 2020 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan settings-sync
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 8, 2020

Currently it appears that when settings sync gets a 401 unauthorized it will continue to sync (and fail) on the standard interval. We should instead stop syncing immediately and show a warning that there is a problem with auth. If the server gives a 401 that means it's available and function and the token failed verification, it is guaranteed to continue to fail verification if the same token is used.

Related #85211 (this is more appropriate for 50x and 404s)

@gjsjohnmurray
Copy link
Contributor

Looks like a dup of #86298

@Tyriar
Copy link
Member Author

Tyriar commented Jan 10, 2020

It is indeed lol, I thought it was a regression. Closing the other one as this has more info.

@sandy081
Copy link
Member

I would not disable sync immediately in this case because auth token is managed by extension and so I would give some chances before stopping sync. Strategy that is followed in this case is mentioned here.

Reiterating here:

Error handling strategy:

  • Sync is disabled automatically for specific errors (large resources - 413)

image

  • Auto sync interval increases by number of failures every time there is an error (other than above)
  • Sync is disabled when there are consecutive 5 failures

image

I think this should not happen, if happens it should be a bug some where (sync, auth or server)

@sandy081
Copy link
Member

Fixed by a27c9fc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan settings-sync
Projects
None yet
Development

No branches or pull requests

4 participants