Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default imports with class types and class-based React components are always appearing styled as classes in latest Insiders #88696

Closed
iansan5653 opened this issue Jan 15, 2020 · 4 comments
Assignees
Labels
javascript JavaScript support issues semantic-tokens Semantic tokens issues

Comments

@iansan5653
Copy link
Contributor

iansan5653 commented Jan 15, 2020

Version: 1.42.0-insider (user setup)
Commit: b40e5ce
Date: 2020-01-15T05:40:15.219Z
Electron: 7.1.7
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.16299

I'm not sure if this is a VSCode issue or an extension, but starting today when I updated to 1.42.0, all default imports of classes, and all TSX tags representing class-based React components, are appearing as green with an underline, a style typically reserved for classes. Before this, tags were italic blue and all imports were white.

Technically the TSX tags do represent class instances, but it makes it very difficult to tell them apart from the component props and they look very strange next to functional components.

Imports example:
image

TSX example:
image

This doesn't happen with the initial load of the file, only after the TS language server starts.

This does still happen with extensions disabled.

@vscodebot vscodebot bot added the javascript JavaScript support issues label Jan 15, 2020
@mjbvz mjbvz added the semantic-tokens Semantic tokens issues label Jan 15, 2020
@iansan5653
Copy link
Contributor Author

Seems to be resolved after updating.

Version: 1.42.0-insider (user setup)
Commit: 33c79d5
Date: 2020-01-15T09:36:35.018Z
Electron: 7.1.7
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.16299

@iansan5653
Copy link
Contributor Author

Never mind, it's still happening.

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 21, 2020

Likely caused by semantic highlighting. Try setting "editor.semanticHighlighting.enabled": false to disable it

@aeschli
Copy link
Contributor

aeschli commented Jan 23, 2020

Duplicate of #88911

@aeschli aeschli marked this as a duplicate of #88911 Jan 23, 2020
@aeschli aeschli closed this as completed Jan 23, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues semantic-tokens Semantic tokens issues
Projects
None yet
Development

No branches or pull requests

3 participants