Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Monaco editor in SCM input #89333

Closed
3 tasks done
joaomoreno opened this issue Jan 27, 2020 · 0 comments
Closed
3 tasks done

Test: Monaco editor in SCM input #89333

joaomoreno opened this issue Jan 27, 2020 · 0 comments
Labels
testplan-item
Milestone
January 2020

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jan 27, 2020 •
edited by deepak1556
Loading

Refs: #84831

Complexity: 4

The SCM input box now uses the Monaco editor.

  • Simple editor features work: multi cursor, selection keybindings, etc
  • Auto sizing works as before: new lines should grow the input box, capped to a certain size
  • Validation works as before: long lines should show a yellow warning
  • Suggest widget is there, but always shows no results
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
4 participants
@joaomoreno @deepak1556 @jrieken @weinand