Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Frame icon overlaps with stacktrace #89472

Closed
chrmarti opened this issue Jan 28, 2020 · 6 comments
Closed

Restart Frame icon overlaps with stacktrace #89472

chrmarti opened this issue Jan 28, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Collaborator

#89393

When there is no line:column indicator:
image

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 28, 2020
@isidorn isidorn added this to the January 2020 milestone Jan 28, 2020
@isidorn
Copy link
Contributor

isidorn commented Jan 29, 2020

To work around the screen cheese in the most simple way I decided to not render the action on hover when the line number is not present. It is still possible to trigger ti via context menu. And in practice I think users will not notice this since the stack frames without line numbers are not really targets for restarting.

@roblourens
Copy link
Member

I think the line number was probably sent (I think it always is?) but isn't being shown due to running out of room. I can still repro this in that case, if I just make the callstack narrow enough to hide the numbers:

image

@roblourens roblourens reopened this Jan 30, 2020
@roblourens roblourens added the verification-found Issue verification failed label Jan 30, 2020
@isidorn isidorn modified the milestones: January 2020, February 2020 Jan 31, 2020
@isidorn isidorn closed this as completed in bc61602 Feb 7, 2020
@connor4312 connor4312 added verified Verification succeeded and removed verification-found Issue verification failed labels Feb 27, 2020
@connor4312
Copy link
Member

The icon now gradually disappears if the text is too long:

adding flex-shrink: 0 on the monaco-action-bar seems like it should fix it

@connor4312 connor4312 reopened this Feb 27, 2020
@connor4312 connor4312 added verification-found Issue verification failed and removed verified Verification succeeded labels Feb 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2020

Not for last day of endgame. Moving to March.
@connor4312 do you want to submit a PR?

@isidorn isidorn modified the milestones: February 2020, March 2020 Feb 27, 2020
@connor4312
Copy link
Member

Sure

@connor4312 connor4312 self-assigned this Feb 27, 2020
@isidorn isidorn closed this as completed in 43f8140 Mar 4, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 4, 2020

@connor4312 thanks for the idea for the fix. Went ahead to no longer have this issue in my to-do list.

@connor4312 connor4312 added verified Verification succeeded and removed verification-found Issue verification failed labels Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants