Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dom-based wrapping: settings name #89573

Closed
kieferrm opened this issue Jan 28, 2020 · 1 comment
Closed

Dom-based wrapping: settings name #89573

kieferrm opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-wrapping Editor line wrapping issues verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

Testing #89389.

The setting name as well as the name of the values are rather technical, even for a code editor. I propose we talk about wrapping strategy rather than algorithm and we use simple for what is now monospace and advanced for what is now dom. The description can then point out what the difference is. We should also add some language to give guidance to user when to use what strategy.

@sana-ajani
Copy link
Contributor

Agreed, I was initially confused by both the values "monospace" and "dom" and the description did not totally clarify the difference. In the description for the setting, it might be helpful to describe what wrapping points are and how this setting is different from editor.wordWrap and editor.wordWrapColumn

@alexdima alexdima added the editor-wrapping Editor line wrapping issues label Jan 29, 2020
@alexdima alexdima added this to the January 2020 milestone Jan 29, 2020
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jan 29, 2020
@Tyriar Tyriar added the verified Verification succeeded label Jan 30, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-wrapping Editor line wrapping issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants