Bad call hierarchy highlights

[jrieken]

TS Template added by @mjbvz

Tested typeScript Version: 3.8.0-dev.20200128

Search Terms

• Call hierarchy
• provideCallHierarchyIncomingCalls
• fromSpans

/cc @rbuckton

---

re microsoft/vscode#89386

• invoke call hierarchy on isFalsyOrWhitespace
• the resolve-child and likely others have broken highlights

[mjbvz]

Here's the result of one of the incoming calls to mergeSort in the VS Code code base:

  {
        "from": {
            "name": "applyEdits",
            "kind": "function",
            "file": "/Users/matb/projects/vscode/src/vs/base/common/jsonEdit.ts",
            "span": {
                "start": {
                    "line": 158,
                    "offset": 1
                },
                "end": {
                    "line": 177,
                    "offset": 2
                }
            },
            "selectionSpan": {
                "start": {
                    "line": 158,
                    "offset": 17
                },
                "end": {
                    "line": 158,
                    "offset": 27
                }
            }
        },
        "fromSpans": [
            {
                "start": {
                    "line": 238,
                    "offset": 98
                },
                "end": {
                    "line": 239,
                    "offset": 8
                }
            }
        ]
    },

The jsonEdit.ts file only has 182 lines so I'm not sure where the fromSpans are coming from.

[mjbvz]

@rbuckton @RyanCavanaugh Can we please investigate this for TS 3.8 (either for the final 3.8 release or for a 3.8.x recovery build that VS code would be able to pick up)

[rbuckton]

My bad, I should have included this as fixed by #36559. It will be in the 3.8 RC.