Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Hierarchy view overview ruler overlaps SCM and caller decorators #89644

Closed
gregvanl opened this issue Jan 29, 2020 · 2 comments
Closed

Call Hierarchy view overview ruler overlaps SCM and caller decorators #89644

gregvanl opened this issue Jan 29, 2020 · 2 comments
Assignees
@jrieken
Labels
*as-designed Described behavior is as designed callhierarchy polish Cleanup and polish issue
Milestone
February 2020

Comments

@gregvanl
Copy link

  • VSCode Version: 1.42 Insiders
  • OS Version: Windows 10

Found while testing #89386

  1. Make a change such as add some new callers.

The green SCM addition region overlaps with the caller decoration.

image
@jrieken jrieken added callhierarchy polish Cleanup and polish issue labels Jan 30, 2020
@jrieken jrieken added this to the February 2020 milestone Jan 30, 2020
@jrieken jrieken added the *as-designed Described behavior is as designed label Feb 5, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 5, 2020

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 5, 2020
@jrieken
Copy link
Member

jrieken commented Feb 5, 2020

Closing this without any change. Looking at our related usages like word highlights or find matches shows that all "discovery" highlights are rendered in the center-lane. With all of them there is potential for overlap and the other alternative is to not have any ruler highlights at all

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
*as-designed Described behavior is as designed callhierarchy polish Cleanup and polish issue
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@jrieken @gregvanl