Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.3 breaks markdown code block highlighting #9032

Closed
uxsoft opened this issue Jul 10, 2016 · 7 comments
Closed

Update 1.3 breaks markdown code block highlighting #9032

uxsoft opened this issue Jul 10, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) markdown Markdown support issues
Milestone

Comments

@uxsoft
Copy link

uxsoft commented Jul 10, 2016

  • VSCode Version: 1.3
  • OS Version: Windows 10 x64

Inside of a csharp code block highlighted properly (vscode 1.2)
vsmarkdown12

Same file loses highlighting with the 1.3 update
vsmarkdown13

@joaomoreno joaomoreno added candidate Issue identified as probable candidate for fixing in the next release bug Issue identified by VS Code Team member as probable bug labels Jul 11, 2016
@joaomoreno joaomoreno added this to the July Stable Recovery milestone Jul 11, 2016
@joaomoreno joaomoreno removed the candidate Issue identified as probable candidate for fixing in the next release label Jul 11, 2016
@joaomoreno joaomoreno removed this from the July Stable Recovery milestone Jul 11, 2016
@glennsarti
Copy link

glennsarti commented Jul 12, 2016

I too am having the issue of code highlighting. I found the syntax highlight can also 'bleed' out of the code block to subsequent text

Test Info:
VS Code :1.3
OS: Mac OSX 10.11.5

Test Case 1

Before

Test_case_1_before

After: Adding a single quote before the word production makes the rest of the code block highlighted, include bleeding out past the end-of-block marker of 3 backticks

Test_case_1_after

Test Case 2

Before - Note that the top code block is prefaced with the powershell type, and bottom code block has no type. And yet the bottom code block is highlighted like a powershell one

Test_case_2_before

After - Removing the powershell code block type at the top also changes the highlighting on the bottom code block. Also note the highlight for the text ### Try out the .... has changed. Before it was powershell highlighted and now it's regular markdown highlighted.

Test_case_2_after

Maybe related to #8636

@schorg
Copy link

schorg commented Jul 12, 2016

I have the same problem, with a language extension I created locally using a .vsix file.

For my installed extensions I observe the following behaviour:

  • The C# language extension does not highlight code blocks.
  • The Lua language extension does highlight code blocks.

Infos:

  • VS Code :1.3
  • OS: Microsoft Windows 7 Professional

@unional
Copy link

unional commented Jul 12, 2016

Another case:
image

@glennsarti
Copy link

Refs: #8259

@gerane
Copy link

gerane commented Jul 13, 2016

It is breaking more than this. There is a long list of issues that I have found, especially in regards to anything related to bullets or asterisks. Ref: #9075

@Thraka
Copy link

Thraka commented Sep 16, 2016

still waiting for a fix 😭

@mjbvz mjbvz added this to the November 2016 milestone Nov 11, 2016
@mjbvz mjbvz added the markdown Markdown support issues label Nov 11, 2016
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 11, 2016

#14626 fixed many of the issues with fenced code blocks leaking their syntax highlighting. Please try out the latest insiders builds and report any additional issues you notice with markdown syntax highlighting. Thanks.

@mjbvz mjbvz closed this as completed Nov 11, 2016
@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

10 participants