Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick access: help, goto line, views #93636

Closed
2 tasks done
bpasero opened this issue Mar 28, 2020 · 0 comments
Closed
2 tasks done

Quick access: help, goto line, views #93636

bpasero opened this issue Mar 28, 2020 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Mar 28, 2020

Refs: #69955

Complexity: 3


Quick open is now using the quick input widget that leverages our new tree widget. All quick open providers have been rewritten from scratch.

All of the existing commands for driving quick open have been preserved. Everything should work as before with some additional features as noted in the test plan.

Note: configure "workbench.quickOpen.closeOnFocusLost": false to make testing easier by keeping quick open opened even if you navigate somewhere else.

Help

  • type ? to enter the help picker
  • verify the entries make sense and are reasonably well explained
  • verify you can either pick an entry or type its prefix to switch to it

Goto Line

  • type : to enter the goto line picker
  • verify you can type :line:column to navigate to line and optional column
  • verify the editor reveals the location in the background if valid
  • verify the editor navigates to the location on enter
  • verify the editor restores its previous view state on escape
  • verify you see a different pick entry when you type invalid line or column
  • verify you see a good hint when you try this picker without editor open or with a non-text editor open
  • verify you can leave the picker open and focus another editor in the background and the picker still works (e.g. you can start from a non-text editor, open goto line picker and then click on a text editor while the picker is open to use it)
  • verify this works on the right hand side of a diff editor when invoked there

Views

  • type view to enter the view picker
  • verify the picks make sense and can be navigated to
  • verify you can filter by name of the view entry
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @weinand @RMacfarlane and others