Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass line number to custom editor when opening custom editors #94037

Closed
DonJayamanne opened this issue Mar 31, 2020 · 3 comments
Closed

Pass line number to custom editor when opening custom editors #94037

DonJayamanne opened this issue Mar 31, 2020 · 3 comments
Assignees
Labels
api custom-editors Custom editor API (webview based editors) feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 31, 2020

@kieferrm as requested, creating a new issue.
Originally posted here #77131 (comment)

Please could you add support for line/column information to the custom editor.
E.g. when users open a file from VS Code (in problems pane or debug stackframe), it opens a file and goes to a specific line number.
We'd like to have this functionality in the notebook editor for DS functionality in the Python extension.

  • This allows us to build a debugger using the VS Code UI (current plan is to build a debugger with a custom bare minimum UI, without stack frames, without variables, etc, i.e. without majority/any of the VS Code debugger UI).
  • Would allow us to add support for notebook outline views
  • This will also allow us to add support for linting (displaying problems related to python code in problems window).
    & more.
@bpasero bpasero removed their assignment Apr 1, 2020
@bpasero bpasero added the custom-editors Custom editor API (webview based editors) label Apr 1, 2020
@mjbvz mjbvz added this to the April 2020 milestone Apr 1, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 14, 2020

There are two cases to handle:

  • Opening a fresh custom editor at a specific line number
  • Telling an existing custom editor to reopen at a specific line number

We could implement the first using the second, e.g. have a method we call to update the line number after creating the initial editor

Related API proposal: #86146

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 22, 2020

I'm prioritizing finalizing custom editors so and will not have time to look into this for April

@mjbvz mjbvz modified the milestones: April 2020, May 2020 Apr 22, 2020
@mjbvz mjbvz added the api label Apr 22, 2020
@mjbvz mjbvz modified the milestones: May 2020, June 2020 May 20, 2020
@mjbvz mjbvz modified the milestones: June 2020, July 2020 Jun 29, 2020
@mjbvz mjbvz modified the milestones: July 2020, On Deck Aug 3, 2020
@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 3, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 2, 2021

Closing this for now due to lack of feedback/additional usecases besides python's custom editors notebooks (which are better served by our notebook api)

@mjbvz mjbvz closed this as completed Mar 2, 2021
@mjbvz mjbvz modified the milestones: On Deck, Backlog Mar 2, 2021
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api custom-editors Custom editor API (webview based editors) feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants