From 2a884eb4d09312e14271596a451b6ecbe31a3109 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 11 Sep 2020 14:54:03 +0200 Subject: [PATCH] proxy authentication does not work on 1.49 (#106434) --- src/vs/code/electron-main/auth.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/code/electron-main/auth.ts b/src/vs/code/electron-main/auth.ts index c1e2a84946af5..d4dfefd7fd144 100644 --- a/src/vs/code/electron-main/auth.ts +++ b/src/vs/code/electron-main/auth.ts @@ -92,9 +92,9 @@ export class ProxyAuthHandler extends Disposable { if (channel === 'vscode:proxyAuthResponse') { const { username, password } = credentials; cb(username, password); + win.removeListener('close', onWindowClose); + win.close(); } - win.removeListener('close', onWindowClose); - win.close(); }); win.loadURL(url); }