IVstestConsoleWrapper.EndSession leaves console processes hanging around

[AbhitejJohn]

Description

Calling into IVsTestConsoleWrapper.EndSession does not automatically dispose vstest.console processes and a StartSession thereafter creates a new process. This is in context of tying in diagnostic logging of vstest.console to an IDE switch so its easier to collect logs.

Expected behavior

vstest.console processes need to be cleaned up/recycled.

Actual behavior

Multiple vstest.console processes lying around.

Environment

I'm trying this on the latest previews of VS 2019 update 2.

[singhsarab]

@ShreyasRmsft Seems to be similar to what we were talking about the other day. Do you have an issue filed already ?

[ShreyasRmsft]

@singhsarab there is an internal bug on mseng. Haven't filed an issue on the repo.

[vagisha-nidhi]

@AbhitejJohn Looked at the issue here. The end session sends a session end message and and when vstest.console receives it, it gets disposed here https://github.com/microsoft/vstest/blob/master/src/Microsoft.TestPlatform.Client/DesignMode/DesignModeClient.cs#L218
There are multiple vstest.console lying around which which is because of this #2034.
I will shortly fix this.

[AbhitejJohn]

@vagisha-nidhi : Thanks, can this issue be closed out now?

[vagisha-nidhi]

@AbhitejJohn Yes. Closing this.

[drognanar]

Reopening this issue as I'm still seeing the vstest.console processes hanging. I'm calling StartSession and EndSession without requesting a discovery and run in between. In this specific case the vstest.console process stays around.

[drognanar]

From my quick look at the code it seems that EndSession does not wait for the handshake with the test console to be established. This introduces a race between the handshake and EndSession messages sent to the testhost.