Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pin Microsoft.Teams.Classic #4339

Closed
otto-liljalaakso-nt opened this issue Apr 2, 2024 · 5 comments
Closed

Cannot pin Microsoft.Teams.Classic #4339

otto-liljalaakso-nt opened this issue Apr 2, 2024 · 5 comments
Labels
Area-Matching Issue related to correlation between installed package and manifest Command-Pin Issue related to WinGet Pin Issue-Bug It either shouldn't be doing this or needs an investigation. Side-by-Side Issue related to side by side package installation
Milestone

Comments

@otto-liljalaakso-nt
Copy link

otto-liljalaakso-nt commented Apr 2, 2024

Brief description of your issue

I have Microsoft Teams installed (by default). It shows up during winget upgrade --all in section The following packages have an upgrade available. Since I have moved to the new teams already quite some time ago, I do not use Teams Classic at all, and I also do not want to manage its updates, because it was installed by default and should be managed by my organization rather than me. In order to spare me from that notification every time I try to upgrade the packages I have installed myself, I attempted to pin that package. Strangely, winget pin add Microsoft.Teams.Classic does not work, even though this method worked for another package (Discord.Discord) I wanted to hide using the same method.

As a workaround, pinning using package name works:

> winget pin add "Microsoft Teams classic"
Found Microsoft Teams classic [Microsoft.Teams.Classic]
Pin added successfully

Steps to reproduce

Precondition: Have Microsoft.Teams.Classic installed in old version:

> winget upgrade
No installed package found matching input criteria.

The following packages have an upgrade available, but require explicit targeting for upgrade:
Name                    Id                      Version      Available   Source
-------------------------------------------------------------------------------
Microsoft Teams classic Microsoft.Teams.Classic 1.6.00.29964 1.7.00.7956 winget
  1. Try to pin it with winget pin add Microsoft.Teams.Classic

Expected behavior

Pin is added and is visible with winget pin list.

Actual behavior

> winget pin add Microsoft.Teams.Classic
No installed package found matching input criteria.
> winget pin list | rg Micrsoft.Teams.Classic
(no output)

Environment

> winget --info
Windows Package Manager v1.7.10861

Windows: Windows.Desktop v10.0.22631.3374
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.10861.0

I already have Microsoft.Teams Teams Machine-Wide Installer pinned for similar reasons.

Copy link

github-actions bot commented Apr 2, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Apr 2, 2024
@otto-liljalaakso-nt
Copy link
Author

Thanks, bot. The issue you found is similar in that:

  1. It is about pinning Microsoft Teams and
  2. There is a workaround that uses package name instead of ID.

But there are also differences:

  1. It is about a package with different ID (Microsoft.Teams.Classic here vs. Microsoft.Teams in that issue)
  2. In that issue, there are two different packages with the same ID installed, whereas here I only see one.

So, I think these are similar but not duplicates. Somebody with knowledge of what is going on internally may be able to judge that the root cause is the same. In that case, please mark this issue as the duplicate of that one.

@denelon
Copy link
Contributor

denelon commented Apr 2, 2024

I'll leave this one independent for now. We've just released a preview to handle some of the Side-By-Side scenarios better, but I think this may also be related to Area-Matching.

@denelon denelon added Area-Matching Issue related to correlation between installed package and manifest Side-by-Side Issue related to side by side package installation Issue-Bug It either shouldn't be doing this or needs an investigation. Command-Pin Issue related to WinGet Pin and removed Needs-Triage Issue need to be triaged labels Apr 2, 2024
@denelon
Copy link
Contributor

denelon commented Jul 3, 2024

Is this still a problem on WinGet 1.8?

@denelon denelon added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jul 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity Issue has no recent activity label Jul 11, 2024
@otto-liljalaakso-nt
Copy link
Author

I confirm that I cannot reproduce the issue any more. I received a new laptop in between, so I had to install an old version Microsoft.Teams.Classic separately to recreate the situation:

> winget --version
v1.8.1911
> winget install Microsoft.Teams.Classic --version 1.6.00.29964
Found Microsoft Teams Classic [Microsoft.Teams.Classic] Version 1.6.00.29964
⋮
Successfully installed
> winget upgrade
No installed package found matching input criteria.

The following packages have an upgrade available, but require explicit targeting for upgrade:
Name                    Id                      Version      Available    Source
--------------------------------------------------------------------------------
Microsoft Teams classic Microsoft.Teams.Classic 1.6.00.29964 1.7.00.19353 winget
> winget pin add Microsoft.Teams.Classic
Found Microsoft Teams classic [Microsoft.Teams.Classic]
Pin added successfully
> winget pin list | rg Microsoft.Teams.Classic
Microsoft Teams classic Microsoft.Teams.Classic 1.6.00.29964 winget Pinning
> winget upgrade
No installed package found matching input criteria.
1 package(s) have pins that prevent upgrade. Use the 'winget pin' command to view and edit pins. Using the --include-pinned argument may show more results.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention Issue needs attention from Microsoft and removed No-Recent-Activity Issue has no recent activity Needs-Author-Feedback Issue needs attention from issue or PR author labels Jul 29, 2024
@denelon denelon removed the Needs-Attention Issue needs attention from Microsoft label Jul 29, 2024
@denelon denelon added this to the 1.9 Client milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Matching Issue related to correlation between installed package and manifest Command-Pin Issue related to WinGet Pin Issue-Bug It either shouldn't be doing this or needs an investigation. Side-by-Side Issue related to side by side package installation
Projects
None yet
Development

No branches or pull requests

2 participants