Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security concern - fetch can accidentally allow users of the lib to allow command injection #102

Closed
kenotron opened this issue Apr 20, 2022 · 0 comments · Fixed by #103
Closed

Comments

@kenotron
Copy link
Member

git fetch has an extra parameter you could potentially use that executes arbitrary commands: --upload-pack. The issue is here:

const results = git(["fetch", remote], { cwd });

and

const results = git(["fetch", remote, remoteBranch], { cwd });

Fix is to add a -- in the arg list like this: fetch -- remote remotebranch. This may not be a big deal, but it has come up as a security issue with other git wrapper libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant