From 557db1949d89073195216037d74c0580e952742d Mon Sep 17 00:00:00 2001
From: EvansA <evansonoka05.j@gmail.com>
Date: Fri, 7 Apr 2023 18:45:34 +0300
Subject: [PATCH] Fix: Missing return statement (#2507)

---
 .../query-runner/request/permissions/TabList.tsx      |  2 +-
 src/tests/ui/anonymous-experiences/request.spec.ts    | 11 +++++++++++
 .../authenticated-experiences.spec.ts                 | 10 ++++++++++
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/app/views/query-runner/request/permissions/TabList.tsx b/src/app/views/query-runner/request/permissions/TabList.tsx
index fd58e2e8a6..f2064c59d5 100644
--- a/src/app/views/query-runner/request/permissions/TabList.tsx
+++ b/src/app/views/query-runner/request/permissions/TabList.tsx
@@ -65,7 +65,7 @@ const TabList = ({ columns, classes, renderItemColumn, renderDetailsHeader, maxH
   }
 
   if(permissions.length === 0){
-    displayNoPermissionsFoundMessage()
+    return displayNoPermissionsFoundMessage();
   }
 
   return (
diff --git a/src/tests/ui/anonymous-experiences/request.spec.ts b/src/tests/ui/anonymous-experiences/request.spec.ts
index 38338523bf..8765b2e3e1 100644
--- a/src/tests/ui/anonymous-experiences/request.spec.ts
+++ b/src/tests/ui/anonymous-experiences/request.spec.ts
@@ -322,6 +322,17 @@ test.describe('Permissions', () => {
     expect(await page.screenshot()).toMatchSnapshot();
     const DirectoryPermission =  page.locator('div[role="gridcell"]:has-text("Directory.Read.AllDirectory.Read.All")');
     expect(DirectoryPermission).toBeDefined();
+  });
+
+  test('should show a message for opening permissions panel when permission requested is not available', async () => {
+    const queryInput = page.locator('[aria-label="Query sample input"]');
+    await queryInput.click();
+    queryInput.fill('https://graph.microsoft.com/v1.0/userssssss');
+    await page.locator('[aria-label="Modify permissions"]').click();
+    await page.evaluate(() => document.fonts.ready);
+    await page.waitForTimeout(100);
+    expect(page.getByText('Permissions for the query are missing on this tab. Sign in to use the Select per')).toBeDefined();
+
   })
 })
 
diff --git a/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts b/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts
index ac5b2f1803..c6f9894527 100644
--- a/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts
+++ b/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts
@@ -45,6 +45,16 @@ test.describe('Request', () => {
     ]);
     expect(page5.url().indexOf('https://jwt.ms/')).toBeGreaterThan(-1);
   })
+
+  test('Permissions tab asks user to open permissions panel to view more permissions if missing on the tab', async () => {
+    const queryInput = authenticatedPage.locator('[aria-label="Query sample input"]');
+    await queryInput.click();
+    queryInput.fill('https://graph.microsoft.com/v1.0/userssssss');
+    await authenticatedPage.locator('[aria-label="Modify permissions"]').click();
+    await authenticatedPage.evaluate(() => document.fonts.ready);
+    await authenticatedPage.waitForTimeout(100);
+    expect(authenticatedPage.getByText('Permissions for the query are missing on this tab. Open the permissions panel to')).toBeDefined();
+  })
 })
 
 test.describe.serial('Profile', () => {