Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop up appears for few seconds on launching GE #1328

Closed
nikithauc opened this issue Dec 23, 2021 · 2 comments · Fixed by #1418
Closed

Pop up appears for few seconds on launching GE #1328

nikithauc opened this issue Dec 23, 2021 · 2 comments · Fixed by #1418
Assignees
Labels
type:bug Something isn't working

Comments

@nikithauc
Copy link

Steps to reproduce:

  1. Lauch GE. The user should be signed in. If not sign in and relaunch a new window and open GE.

A pop-up starts to appear and disappears before the the dialog is loaded successfully.

@ghost ghost added the ToTriage label Dec 23, 2021
@ElinorW ElinorW self-assigned this Jan 12, 2022
@ghost ghost removed the ToTriage label Jan 12, 2022
@ElinorW ElinorW added the status:waiting-for-dependency An issue that has core project dependency that's currently blocking it label Jan 12, 2022
@ElinorW ElinorW added this to the Jan 06 - Feb 03 milestone Jan 17, 2022
@ElinorW
Copy link
Contributor

ElinorW commented Jan 20, 2022

From investigation,

  • Pop-up appears because of the MSAL Auth library.
  • This disappears because there's a token call (in the background) that's failing.
  • This token call fails because we have permissions that haven't been enabled on the ADO. Enabling these permissions causes a different pop-up that requires admin consent.
  • For us to get admin consent we have to complete our privacy and compliance checks, which are currently in progress.

Image of pop up when permissions are enabled
image

@ElinorW
Copy link
Contributor

ElinorW commented Jan 20, 2022

We will temporarily stop the background call until we are done with our privacy and compliance checks and thus we can get admin consent for the permissions.

@adhiambovivian adhiambovivian added type:bug Something isn't working and removed status:waiting-for-dependency An issue that has core project dependency that's currently blocking it Bug – P2 labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants