Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto-Complete] Investigate why auto-complete is not working for non-GET queries and make necessary fixes #1773

Closed
RabebOthmani opened this issue May 31, 2022 · 2 comments · Fixed by #1802
Closed

[Auto-Complete] Investigate why auto-complete is not working for non-GET queries and make necessary fixes #1773

RabebOthmani opened this issue May 31, 2022 · 2 comments · Fixed by #1802
Assignees
@thewahome
Labels
Area: Autocomplete priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs
Milestone
June-2022

Comments

@RabebOthmani
Copy link

This appears to be a bug. Upon investigation and requesting context, there is nothing in the original implementation that would stop auto-complete from working with non-GET queries.
The ask here is to confirm if this is a bug, in which case we should fix it.
@RabebOthmani RabebOthmani added Area: Autocomplete priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs labels May 31, 2022
@RabebOthmani RabebOthmani added this to the June-2022 milestone May 31, 2022
@ghost ghost added the ToTriage label May 31, 2022
@ghost ghost removed the ToTriage label May 31, 2022
@adhiambovivian adhiambovivian changed the title [Auto-Complete] Investigate why auto-complete is not working for non-GET queries [Auto-Complete] Investigate why & fix auto-complete is not working for non-GET queries Jun 2, 2022
@adhiambovivian adhiambovivian changed the title [Auto-Complete] Investigate why & fix auto-complete is not working for non-GET queries [Auto-Complete] Investigate why auto-complete is not working for non-GET queries and make necessary fixes Jun 2, 2022
@thewahome thewahome linked a pull request Jun 8, 2022 that will close this issue
Feature: autocomplete typeahead #1802
Merged
@thewahome
Copy link
Collaborator

Autocomplete fully depended on the links provided by making a call to the autocomplete endpoint. Part of the payload is a links property that has all the paths we can use. These links are only present in the get segment of the response.

From consultations with @irvinesunday there was no need to also place the paths in the other methods. This for us means that we can assume that the paths available in the get method are available in the other methods.

@thewahome
Copy link
Collaborator

This means that the approach to fixing it should assume that the autocomplete options are available for all methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thewahome thewahome

Labels
Area: Autocomplete priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs
Projects
None yet
Milestone
June-2022
Development

Successfully merging a pull request may close this issue.

Feature: autocomplete typeahead microsoftgraph/microsoft-graph-explorer-v4
2 participants
@RabebOthmani @thewahome