Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 share links from Graph Explorer when URL includes query parameters #1986

Closed
FaithOmbongi opened this issue Aug 2, 2022 · 3 comments
Closed
Assignees
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. type:bug Something isn't working
Milestone

Comments

@FaithOmbongi
Copy link

FaithOmbongi commented Aug 2, 2022

The Graph Explorer "share" button generates a shareable link but I see the "value" part of the query string is replaced with a placeholder <value>. Unfortunately, customers are getting a 404 error for such links because the "<" and ">" symbols get encoded as well.

Example: (Repro steps)

I think if the intent is to not share sensitive values, maybe remove the "<" ">" symbols and say "value" instead?

For example, the above link would be

https://developer.microsoft.com/en-us/graph/graph-explorer?request=users%3F%24filter%3DdisplayName%2Beq%2Bvalue&method=GET&version=v1.0&GraphUrl=https://graph.microsoft.com

I'm also not sure it's appropriate to hide the values. I assume that a customer intending to share a shareable link either intends to share the link as-is or they are OK with sharing the test values publicly because they've already sanitized the value part of the query string.

@ghost ghost added the ToTriage label Aug 2, 2022
@Onokaev Onokaev added this to the Aug-2022 milestone Aug 2, 2022
@ghost ghost removed the ToTriage label Aug 2, 2022
@Onokaev
Copy link
Contributor

Onokaev commented Aug 2, 2022

Related to #1991

@Onokaev
Copy link
Contributor

Onokaev commented Aug 3, 2022

This has been fixed. It's in the coming release

@Onokaev Onokaev closed this as completed Aug 3, 2022
@Onokaev
Copy link
Contributor

Onokaev commented Aug 22, 2022

#1993

@adhiambovivian adhiambovivian added type:bug Something isn't working priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. and removed Bug – P1 labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants