Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deep copy in recursive function #2152

Closed
thewahome opened this issue Oct 6, 2022 · 1 comment · Fixed by #2151
Closed

Remove deep copy in recursive function #2152

thewahome opened this issue Oct 6, 2022 · 1 comment · Fixed by #2151
Assignees

Comments

@thewahome
Copy link
Collaborator

Describe the bug
microsoft-graph-explorer-v4/resources-filter.ts at dev · microsoftgraph/microsoft-graph-explorer-v4 (github.com)

This call is deserializing/serializing trees and subtrees in a recursive fashion. It's expensive, memory consuming, and basically useless. It can be done once before getting in that function and the work is done. This is invoked every time you change a character that is not part of the query string. Since an object is a tree, the dump/parse loop is basically done on sub-items in a repetitive fashion.

@ghost ghost added the ToTriage label Oct 6, 2022
@thewahome
Copy link
Collaborator Author

As pointed out by @MaximRouiller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant