Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Consent type flipping #2453

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Fix: Consent type flipping #2453

merged 6 commits into from
Mar 16, 2023

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Mar 13, 2023 •
edited
Loading

Overview

Closes #2438

Demo

Optional. Screenshots, curl examples, etc.

Notes

Propagation of consented permissions takes time. As a result, subsequent calls to the token endpoint may not immediately return an already consented scope. This issue is however intermittent.

Testing Instructions

  • How to test this PR
    Sign in with the staging link
    Consent to permissions
    Notice that the consent button no longer flips

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2453.centralus.azurestaticapps.net

@Onokaev Onokaev marked this pull request as ready for review March 15, 2023 08:33
calebkiage
calebkiage reviewed Mar 15, 2023
View reviewed changes
Copy link

@calebkiage calebkiage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some CSS related comments.

@microsoftgraph microsoftgraph deleted a comment from github-actions bot Mar 15, 2023
@microsoftgraph microsoftgraph deleted a comment from sonarqubecloud bot Mar 15, 2023
@microsoftgraph microsoftgraph deleted a comment from github-actions bot Mar 15, 2023
@microsoftgraph microsoftgraph deleted a comment from github-actions bot Mar 15, 2023
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2453.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2453.centralus.azurestaticapps.net

@Onokaev Onokaev requested review from thewahome and calebkiage March 16, 2023 08:03
@Onokaev Onokaev merged commit 8261a09 into dev Mar 16, 2023
@Onokaev Onokaev deleted the fix/consented-status branch March 16, 2023 09:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

This was referenced Sep 25, 2024
Closed
Closed
Merged
@release-please release-please bot mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Onokaev @calebkiage @thewahome