-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove the replacement of escape characters in json response formatting #3163
Conversation
Signed-off-by: Musale Martin <[email protected]>
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3163.centralus.azurestaticapps.net |
@musale have you confirmed this to work with Safari? If this change makes the replacement code unnecessary, then we might not need to stringify then parse. We can just pass the Json as is and get rid of this function |
Pinging @Onokaev to validate this on Safari. |
Thank you @SilasKenneth! Also tested the paths in the #895 and they work as expected. |
@musale since the test works, the stringify -> parse is an unnecessary set of legacy steps. Is this something that we can confidently remove? |
Sure! Unless that telemetry is important, I don't see the need for that function too. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3163.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3163.centralus.azurestaticapps.net |
|
Overview
Removes replacement of escaped characters in the stringified json.
closes #3158
Testing Instructions
https://graph.microsoft.com/v1.0/appCatalogs/teamsApps?$expand=*