Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFR is not using the TsigProvider #1300

Closed
dmavrommatis opened this issue Sep 22, 2021 · 2 comments · Fixed by #1331
Closed

XFR is not using the TsigProvider #1300

dmavrommatis opened this issue Sep 22, 2021 · 2 comments · Fixed by #1331

Comments

@dmavrommatis
Copy link
Contributor

Even if the TsigProvider is set on the connection/transfer struct the read/write functions do not use the provider.

https://github.com/miekg/dns/blob/master/xfr.go#L215-L254
@tmthrgd
Copy link
Collaborator

tmthrgd commented Oct 28, 2021

Am I right in thinking that this issue, #1296, #1187 (comment) and #1254 (comment) are all essentially the same issue you're facing? I think we can probably have Transfer support TsigProvider without too much difficulty.

@dmavrommatis
Copy link
Contributor Author

Yes, it's the same issue. First I thought that the problem was just the fact that the functions are not exported. Then I saw that for xfr and dns server is not implemented at all while md5 is deprecated.

@dmavrommatis dmavrommatis mentioned this issue Oct 28, 2021
Closed
@tmthrgd tmthrgd mentioned this issue Oct 30, 2021
Closed
@Fattouche Fattouche mentioned this issue Jan 5, 2022
Closed
This was referenced Jan 20, 2022
Closed
Merged
@cbot cbot bot closed this as completed in #1331 Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tmthrgd @dmavrommatis