Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule default-param-last enforced, contradicting eslint-standard #589

Closed
paperrin opened this issue Jun 11, 2021 · 2 comments · Fixed by #591
Closed

Rule default-param-last enforced, contradicting eslint-standard #589

paperrin opened this issue Jun 11, 2021 · 2 comments · Fixed by #591

Comments

@paperrin
Copy link

paperrin commented Jun 11, 2021 •
edited
Loading

What version of this package are you using?
using ts-standard 10.0.0
which is using 20.0.0 of this package

What operating system, Node.js, and npm version?
Windows 10
Node 14.15.1
NPM 7.5.2

What happened?
This rule is enforced

'@typescript-eslint/default-param-last': 'error'

What did you expect to happen?
Expected rule to be relaxed like it was on standard/eslint-config-standard@25a0d26

Are you willing to submit a pull request to fix this bug?
Would be my first contribution to open source, of course I would.
@theoludwig
Copy link
Contributor

Thanks for your report! @paperrin

@mightyiam Do you think it is viable to disable this rule as standard did ?

@mightyiam
Copy link
Owner

Yes, consistency with standard is desirable.

@theoludwig theoludwig mentioned this issue Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: relax rule default-param-last mightyiam/eslint-config-love
3 participants
@mightyiam @paperrin @theoludwig