Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
engineio.Server
throws an error when theresource
keyword argument is provided because it is not one of the options. These changes fix the issue.On a side note:
I spent a few minutes trying to write a test case for this but the module seems very fragile. Some of the issues I've noticed:
init_app()
style does not work.SocketIO.on
decorator uses uninitialized valuesif self.server is None: self.run(app)
inSocketIO.test_client
doesn't make sense because the run method never initializesself.server
causing variousNoneType
attribute errors