You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrading from 4 to 5, the following code started ignoring the room parameter and sending a message to everyone. Looking at the changelog, it appears that the room parameter has been renamed to.
I believe it would help avoid surprises if an error was thrown when room is passed. Or to treat room as an alias for to (like python-socketio) and issuing a deprecation warning.
Greetings and thanks for your work !
After upgrading from 4 to 5, the following code started ignoring the
room
parameter and sending a message to everyone. Looking at the changelog, it appears that theroom
parameter has been renamedto
.I believe it would help avoid surprises if an error was thrown when
room
is passed. Or to treatroom
as an alias forto
(like python-socketio) and issuing a deprecation warning.Here's the requirements.txt diff :
Thanks again,
Pierre
The text was updated successfully, but these errors were encountered: