fix test_client connected error #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server disconnects all clients, only one testclient will disconnect.
When disconnecting, messages before disconnection can not received.
|
I don't understand what is the issue that this change addresses. Can you provide an example please? |
|
I add an example in test. |
Codecov Report
@@ Coverage Diff @@
## main #1829 +/- ##
==========================================
- Coverage 79.24% 78.64% -0.60%
==========================================
Files 3 3
Lines 371 370 -1
Branches 73 72 -1
==========================================
- Hits 294 291 -3
- Misses 56 59 +3
+ Partials 21 20 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -237,7 +237,7 @@ def on_json(self, data): | |||
| return data | |||
|
|
|||
| def on_exit(self, data): | |||
| disconnect() | |||
There was a problem hiding this comment.
this change seems unrelated
| @@ -203,8 +204,6 @@ def get_received(self, namespace=None): | |||
| namespace is assumed if this argument is not | |||
| provided. | |||
| """ | |||
| if not self.is_connected(namespace): | |||
| raise RuntimeError('not connected') | |||
|
Thanks, I do understand the problem now. I have addressed in a slightly different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server disconnects all clients, only one testclient will disconnect.