More secure nginx configuration examples #1966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Nginx example configuration in the docs is potentially vulnerable.
This PR fixes that to avoid people introducing potential issues in their apps when copy-pasting that configuration.
Explaination
This is the current configuration:
in case there are two separate folders,
<path-to-your-application>/static
and<path-to-your-application>/static_secret
this setup would allow an attacker to access all the files contained in/static_secret
just by requestinghttp://[domain]/static_secret/[file]
. Adding a final slash ensures only thestatic
folder is served.Note that as we add the slash to
alias <path-to-your-application>/static/
, it's extremely important that we add the final slash tolocation /static/
as well, as a lack of this would lead to a much more serious path traversal vulnerability[1][2]