-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cookie handling API changed in Werkzeug 2.3 #1982
Comments
For anyone else who has the same issue, you can make a quick fix by replacing
It does the same as the original werkzeug inject_wsgi: This also uses hidden cookie functions, so it's not recommended :) |
* Upgraded Werkzeug to >3.0.0 * Werkzeug's `Response.charset` got removed. See pallets/werkzeug#2768 * Upgraded Flask to >3.0.0 * FlaskClient.cookie_jar was affected due to changes in Werkzeug Flask just removed CookieJar alltogether, while also checking the path of cookies in the tests more strictly. See: miguelgrinberg/Flask-SocketIO#1982 See: pallets/flask#5053 * Cookie values now only accept strings and not bytes. Change-Id: Id1a8014f826254235866e86b936bb2a5c720219a
* Upgraded Werkzeug to >3.0.0 * Werkzeug's `Response.charset` got removed. See pallets/werkzeug#2768 * Upgraded Flask to >3.0.0 * FlaskClient.cookie_jar was affected due to changes in Werkzeug Flask just removed CookieJar alltogether, while also checking the path of cookies in the tests more strictly. See: miguelgrinberg/Flask-SocketIO#1982 See: pallets/flask#5053 * Cookie values now only accept strings and not bytes. Change-Id: Id1a8014f826254235866e86b936bb2a5c720219a
* Upgraded Werkzeug to >3.0.0 * Werkzeug's `Response.charset` got removed. See pallets/werkzeug#2768 * Upgraded Flask to >3.0.0 * FlaskClient.cookie_jar was affected due to changes in Werkzeug Flask just removed CookieJar alltogether, while also checking the path of cookies in the tests more strictly. See: miguelgrinberg/Flask-SocketIO#1982 See: pallets/flask#5053 * Cookie values now only accept strings and not bytes. Change-Id: Id1a8014f826254235866e86b936bb2a5c720219a
As part of our python3.12 upgrade, we have also upgraded all our packages. It seems that the werkzeug have deprecated the `cookie_jar` in the testing client[1]. This commit fixes any tests broken but changed behaviour of cookies due to the flask and werkzeug upgrades. Most of these changes use the simplified cookie interface `get_cookie` (this may have always been there but was missed during initial development). [1] miguelgrinberg/Flask-SocketIO#1982
As part of our python3.12 upgrade, we have also upgraded all our packages. It seems that the werkzeug have deprecated the `cookie_jar` in the testing client[1]. This commit fixes any tests broken but changed behaviour of cookies due to the flask and werkzeug upgrades. Most of these changes use the simplified cookie interface `get_cookie` (this may have always been there but was missed during initial development). [1] miguelgrinberg/Flask-SocketIO#1982
As part of our python3.12 upgrade, we have also upgraded all our packages. It seems that the werkzeug have deprecated the `cookie_jar` in the testing client[1]. This commit fixes any tests broken but changed behaviour of cookies due to the flask and werkzeug upgrades. Most of these changes use the simplified cookie interface `get_cookie` (this may have always been there but was missed during initial development). [1] miguelgrinberg/Flask-SocketIO#1982
As part of our python3.12 upgrade, we have also upgraded all our packages. It seems that the werkzeug have deprecated the `cookie_jar` in the testing client[1]. This commit fixes any tests broken but changed behaviour of cookies due to the flask and werkzeug upgrades. Most of these changes use the simplified cookie interface `get_cookie` (this may have always been there but was missed during initial development). [1] miguelgrinberg/Flask-SocketIO#1982
API change in Werkzeug 2.3: https://werkzeug.palletsprojects.com/en/2.3.x/changes/#version-2-3-0
Affected code in flask-socketio:
Flask handled the changes as follows: pallets/flask#5053
The text was updated successfully, but these errors were encountered: