request context should not be needed when calling emit() with namespace #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a minor issue with
emit()
, which used to require a request context even when the namespace argument was specified. This happens becausekwargs.get()
evaluates its second argument in an eager manner. The pull request fixes this by replacingkwargs.get()
with a membership check, falling back to the namespace of the current request context only if thenamespace
keyword argument is not present.