Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --with(out)-threads for compatibility #659

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

kzidane
Copy link
Contributor

@kzidane kzidane commented Mar 9, 2018

In CS50 (Introduction to Computer Science) at Harvard we use Flask in the second half of the course. We have our own customized development environment (CS50 IDE) which is a cloud-based IDE based on Cloud9 that students are encouraged to use since it allows them to try any of the code demos if they want and start working on their assignments immediately without having to worry about setting up and configuring a local development environment.

In this environment we provide students with a wrapper around the flask CLI to abstract some of the complexities away from them. At the end of the course, students decide on a final project as their graduation project and they're allowed to use any environment(s) and toolset(s) that appeal. Some of them choose to work on the CS50 IDE and develop web apps that use Flask-SocketIO. But because our flask CLI wrapper passes --with-threads by default and Flask-SocketIO doesn't recognize this option, their flask runs fail.

I know Flask-SocketIO uses threads so --with-threads is implied, but just for compatibility with the original flask CLI, this PR just adds support for the --with(out)-threads dummy options.

cc @dmalan

#604

@miguelgrinberg miguelgrinberg merged commit f08cc23 into miguelgrinberg:master Mar 9, 2018
@miguelgrinberg
Copy link
Owner

Yes, this makes perfect sense. Thanks!

@kzidane kzidane deleted the threads branch March 9, 2018 20:37
@dmalan
Copy link

dmalan commented Mar 10, 2018

Thank you, @miguelgrinberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants