support --with(out)-threads for compatibility #659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CS50 (Introduction to Computer Science) at Harvard we use
Flask
in the second half of the course. We have our own customized development environment (CS50 IDE) which is a cloud-based IDE based on Cloud9 that students are encouraged to use since it allows them to try any of the code demos if they want and start working on their assignments immediately without having to worry about setting up and configuring a local development environment.In this environment we provide students with a wrapper around the
flask
CLI to abstract some of the complexities away from them. At the end of the course, students decide on a final project as their graduation project and they're allowed to use any environment(s) and toolset(s) that appeal. Some of them choose to work on the CS50 IDE and develop web apps that useFlask-SocketIO
. But because ourflask
CLI wrapper passes--with-threads
by default andFlask-SocketIO
doesn't recognize this option, theirflask run
s fail.I know
Flask-SocketIO
uses threads so--with-threads
is implied, but just for compatibility with the originalflask
CLI, this PR just adds support for the--with(out)-threads
dummy options.cc @dmalan
#604